fix(ci): remove isStaleCiRun to prevent ci pr hang on SSH host-key prompt#10300
Merged
davidfirst merged 1 commit intomasterfrom Apr 15, 2026
Merged
fix(ci): remove isStaleCiRun to prevent ci pr hang on SSH host-key prompt#10300davidfirst merged 1 commit intomasterfrom
davidfirst merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI PR staleness check to avoid hanging CI runners when git fetch origin triggers an interactive SSH host-key prompt, ensuring bit ci pr can continue its retry flow without waiting for a step timeout.
Changes:
- Run the
git fetch origininsideisStaleCiRun()with a non-interactive SSH configuration (BatchMode + bounded ConnectTimeout). - Keep existing behavior on failure: fall back to treating the run as “fresh” so the retry logic proceeds.
davidfirst
force-pushed
the
fix/ci-pr-git-fetch-hang-on-ssh-prompt
branch
from
bdc881a to
44b806f
Compare
davidfirst
changed the title
GiladShoham
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10297. The new `isStaleCiRun` helper runs `git fetch origin` inside the hash-mismatch retry path. In the `bit_pr` CircleCI job, `origin` is the default SSH remote and GitHub's host key isn't seeded in `known_hosts` for that job's shell — so the fetch hits an interactive "yes/no" host-key prompt and hangs the job until the 50-minute step timeout (seen on #10257). The `bit_merge` job avoids this only because it rewrites `origin` to an HTTPS+token URL via `update_ssh_agent`; `bit_pr` does not.
`isStaleCiRun` was added during PR review to guard a hypothetical race: an older CI run finishing later could delete a newer run's lane and re-export stale snaps. In practice that race is unlikely, self-correcting (the next CI run on the latest commit publishes the correct lane), and only affects a PR lane — not main. Removing the guard restores the original simple retry from #10297, which is enough.