Skip to content

fix(controller): revert release.check_image_access for now#103

Merged
Cryptophobia merged 6 commits into
teamhephy:masterfrom
Cryptophobia:master
Jun 18, 2019
Merged

fix(controller): revert release.check_image_access for now#103
Cryptophobia merged 6 commits into
teamhephy:masterfrom
Cryptophobia:master

Conversation

@Cryptophobia

Copy link
Copy Markdown
Member

Reverting #88 and #90 .

Because of problems with user who have 400+ apps such as these #101

@kingdonb kingdonb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've received reports from at least two users that we broke something with this change after v2.20.0

@duanhongyi duanhongyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cryptophobia

Copy link
Copy Markdown
Member Author

Thank you guys! Merging this now.

@Cryptophobia
Cryptophobia merged commit cb94147 into teamhephy:master Jun 18, 2019
kingdonb pushed a commit to kingdonb/controller that referenced this pull request Aug 6, 2019
fix(controller): revert release.check_image_access for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants