chore: Revise trigger message to include IP address [CHI-3828]#4271
Merged
chore: Revise trigger message to include IP address [CHI-3828]#4271
Conversation
Collaborator
Author
|
@copilot Take a look at the failing unit tests and fix them in a separate PR (to be merged against this one).
|
Contributor
6 tasks
Collaborator
Author
|
@copilot In a new PR, add unit tests for the changes in this PR:
|
Contributor
6 tasks
…n reducer new actions [CHI-3828] Agent-Logs-Url: https://github.com/techmatters/flex-plugins/sessions/c23b823e-464f-47a2-97d4-4b403e917f97 Co-authored-by: gpaoloni <15805319+gpaoloni@users.noreply.github.com>
test: Add unit tests for MessagingCanvasPhase auto-message and session reducer actions [CHI-3828]
stephenhand
approved these changes
May 1, 2026
stephenhand
reviewed
May 5, 2026
| ipAddress || | ||
| localizeKey(currentTranslations)('Conversation-Participants-CustomerDefaultName') || | ||
| DEFAULT_CUSTOMER_DEFAULT_NAME; | ||
| const message = `${autoFirstMessage} ${contactIdentifierWithDefaults}`; |
Collaborator
There was a problem hiding this comment.
Sorry, missed this. We should always use interpolated string keys for dynamic data like this rather than hardcoding the interpolation. People may not always want the contact identifier to come at the end of their message
Also fallbacks like DEFAULT_AUTO_FIRST_MESSAGE are pointless, localizeKey returns the unmodified key if no translation can be found anywhere in the hierarchy, not a falsey value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P