fix: Update unit tests to match revised IP capture behavior [CHI-3828]#4279
Closed
Copilot wants to merge 2 commits intogian_CHI-3828from
Closed
fix: Update unit tests to match revised IP capture behavior [CHI-3828]#4279Copilot wants to merge 2 commits intogian_CHI-3828from
Copilot wants to merge 2 commits intogian_CHI-3828from
Conversation
6 tasks
…ssing Agent-Logs-Url: https://github.com/techmatters/flex-plugins/sessions/4fa73bc9-a0a6-4c53-b55f-7aa5df3851be Co-authored-by: gpaoloni <15805319+gpaoloni@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Chore: Revise trigger message to include IP address
fix: Update unit tests to match revised IP capture behavior [CHI-3828]
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes unit tests broken by the CHI-3828 changes that moved IP lookup responsibility into
getUserIpitself. Previously the call site guarded against a missingipLookupServiceApiKeybefore callinggetUserIp; nowgetUserIpaccepts an optional key and returns'0.0.0.0'internally when it's absent.genericActions.test.ts"should not fetch ip when captureIp is true but ipLookupServiceApiKey is not set"—getUserIpis now always called whencaptureIp: true, passingundefinedwhen no key is configured. Test now asserts it's called withundefinedand that the fallback IP appears informData.ipTracker.test.tsgetUserIp(undefined)returns'0.0.0.0'without invokingfetch.Checklist
Other Related Issues
None
Verification steps
Run the webchat test suite:
All 406 tests pass across 48 suites.
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P