Skip to content

Add ability to remove message file attachments - #4587

Merged
janorivera merged 6 commits into
masterfrom
alejandro/usnm/add_ff_enable_file_attachments
Aug 8, 2026
Merged

Add ability to remove message file attachments#4587
janorivera merged 6 commits into
masterfrom
alejandro/usnm/add_ff_enable_file_attachments

Conversation

@janorivera

@janorivera janorivera commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Description

NAMI requested this and they shared the line we needed to add so I took a stab a it.
The attachment button is there by default to in order to make the ff to remain as an "enable" I had to do the if(!feature_flag)

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags added
  • Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@janorivera janorivera changed the title WP Add ability to remove message file attachments Add ability to remove message file attachments Aug 5, 2026

@stephenhand stephenhand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor nit, could you update the config property name to something that makes it clear the flag controls file attaching in flex rather for service users. Like allowOutgoingAttachments or allowFlexToSendAttachments

Or you might consider making the flag negative. preventSendingAttachmentsFromFlex. This has 2 benefits. One, it indicates more clearly this is a standard flex feature we are turning off, rather than one of our features we are turning on. Two, it means that current behaviour will be preserved with no config being applied to a helpline. If I understand correctly, as it currently stands we would have to apply configuration to every helpline before deploying this code to prevent attachments being disabled for them

@gpaoloni gpaoloni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

(agree with Steve's comment on the naming)

@janorivera

Copy link
Copy Markdown
Collaborator Author

thanks guys! I made the updates so I'll merge it now

@janorivera
janorivera merged commit d1476d8 into master Aug 8, 2026
23 checks passed
@janorivera
janorivera deleted the alejandro/usnm/add_ff_enable_file_attachments branch August 8, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants