Fix build and warnings - #78
Merged
Merged
Conversation
danifunker
commented
Aug 8, 2026
danifunker
commented
Contributor
- builds were fixed as I was working on it, so it was rebased
- remove all compilation warnings
2be036c ported the GUI's live MIPS estimate onto CyclesPtr, so the worker now holds a raw pointer into the Machine's MipsCore. Every path that drops the machine has to clear it first — a use-after-free the compiler can't catch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- winit 0.30: EventLoop::run is deprecated, so Ui::run's closure becomes a UiApp ApplicationHandler driven by run_app. Pure mechanical move — run_app is literally run() with a dispatch closure, same events. - raw-window-handle 0.6: HasRawWindowHandle/raw_window_handle() are deprecated; use HasWindowHandle + window_handle().as_raw(). - unused mut in mips_cache_v2 (only opcodefusion writes prev_s1) and in main.rs (only the pcap prompt writes cfg). - coffdump's Fdr/Pdr mirror on-disk records: allow(dead_code). - drop the unused SOCKET_FILTERS const in iris-gui. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
--features r5k,r5ksc_triton has not compiled since the Triton L2-enable sync landed: `cache` needs to be mut for set_l2_enabled. Only that feature writes it, so the mut is paired with a cfg'd allow(unused_mut). Also silence unreachable_code on idle_state, which follows the jit dispatch's return when both features are on (iris-gui's premiere build). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.