Skip to content

Fix manual rollout completion#209

Merged
arjunkomath merged 1 commit into
mainfrom
fix/empty-service-update-on-rollout
Jul 25, 2026
Merged

Fix manual rollout completion#209
arjunkomath merged 1 commit into
mainfrom
fix/empty-service-update-on-rollout

Conversation

@arjunkomath

Copy link
Copy Markdown
Member

Summary

  • avoid issuing an empty Drizzle service update when completing manually placed stateless rollouts
  • derive the optional service update once and only execute it when rollout completion has service metadata to persist
  • preserve automatic placement timestamps and stateful server locking

Root cause

completeRollout conditionally populated the service update with lastAutomaticPlacementAt for automatic placement and lockedServerId for stateful services. A manually placed stateless service satisfied neither condition, so Drizzle received .set({}) and threw No values to set after routing sync.

Validation

  • cd web && pnpm test (290 tests)
  • cd web && ./node_modules/.bin/tsc --noEmit
  • cd web && npx biome check --write lib/inngest/functions/rollout-helpers.ts
  • verified the affected local Inngest retry completed and stopped the old deployments after loading the fix

Review

  • Odin review: no blocking findings; agreed the implementation is minimal and the no-test decision is reasonable

@github-actions

Copy link
Copy Markdown

React Doctor found no issues. 🎉

⚠️ Warning: .github/workflows/react-doctor.yml is configured incorrectly. See below to fix.

React Doctor compares against main to report only the issues this pull request introduces. This run couldn't complete that comparison (usually a shallow CI checkout with no merge base), so it listed every issue in the changed files, including ones that already existed on main.

Add fetch-depth: 0 to the actions/checkout step in .github/workflows/react-doctor.yml so the checkout includes the history React Doctor needs:

 jobs:
   react-doctor:
     steps:
       - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0

       - uses: millionco/react-doctor@v2

To silence this warning, set silence-missing-baseline-warning: true on the React Doctor action.

Reviewed by React Doctor for commit 4edd6fc.

@arjunkomath
arjunkomath merged commit 478ed4a into main Jul 25, 2026
7 checks passed
@arjunkomath
arjunkomath deleted the fix/empty-service-update-on-rollout branch July 25, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant