Skip to content

Show feedback when deploy actions fail - #227

Merged
arjunkomath merged 1 commit into
mainfrom
fix/deploy-error-feedback
Jul 29, 2026
Merged

Show feedback when deploy actions fail#227
arjunkomath merged 1 commit into
mainfrom
fix/deploy-error-feedback

Conversation

@arjunkomath

Copy link
Copy Markdown
Member

Summary

  • show an error toast when starting a deployment or build fails
  • use action-specific fallback messages when no error message is available
  • keep rollout-cache refresh failures from being presented as deployment failures

Verification

  • npx biome check --write components/service/details/pending-changes-banner.tsx
  • ./node_modules/.bin/tsc --noEmit
  • Kimi K3 review: approved with no blocking findings

Test limitation

  • ./node_modules/.bin/vitest run tests/deploy-service-revision.test.ts could not start in the orb because it has Node 20.9.0, while the installed Vitest/Rolldown toolchain requires a newer Node runtime (node:util.styleText is unavailable).

Amp-Thread-ID: https://ampcode.com/threads/T-019fac15-2fd1-75fe-9990-85235eaeb481
Co-authored-by: Arjun Komath <arjunkomath@gmail.com>
@github-actions

Copy link
Copy Markdown

React Doctor found no issues. 🎉

⚠️ Warning: .github/workflows/react-doctor.yml is configured incorrectly. See below to fix.

React Doctor compares against main to report only the issues this pull request introduces. This run couldn't complete that comparison (usually a shallow CI checkout with no merge base), so it listed every issue in the changed files, including ones that already existed on main.

Add fetch-depth: 0 to the actions/checkout step in .github/workflows/react-doctor.yml so the checkout includes the history React Doctor needs:

 jobs:
   react-doctor:
     steps:
       - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0

       - uses: millionco/react-doctor@v2

To silence this warning, set silence-missing-baseline-warning: true on the React Doctor action.

Reviewed by React Doctor for commit dedfa4a.

@arjunkomath
arjunkomath merged commit e9f51f6 into main Jul 29, 2026
8 checks passed
@arjunkomath
arjunkomath deleted the fix/deploy-error-feedback branch July 29, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants