fix(sql-editor): skip Safe mode confirm for SELECT/JOIN reads - #245
Merged
Conversation
The Tables≥ threshold was prompting on any statement that referenced enough tables, including read-only SELECT joins. Multi-table confirm now applies only to write statements (UPDATE/DELETE/INSERT/DDL). Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
huyplb
marked this pull request as ready for review
August 13, 2026 06:09
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_4f059373-111d-4b5b-b3b0-2bcdedbfe26e) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Safe mode’s Tables≥ threshold treated every statement that referenced enough tables as confirmation-worthy — including read-only
SELECT … JOIN … JOIN …queries. That dialog is meant to suggest wrapping related writes in a transaction; a multi-table SELECT is not a write.Change
collectMultiTableWriteWarnings(statements, threshold)skips statements that are not writes (isWriteStatement).WITH … SELECTreads no longer open the Safe mode dialog.SELECT … INTO(and other writes) that meet the threshold still warn.Tests
Unit coverage in
sql-splitter.test.tsfor SELECT joins, mixed batches,SELECT INTO, and threshold0.