Phases added dynamically to a step are added to its queue too#4750
Merged
Phases added dynamically to a step are added to its queue too#4750
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors how guest instances are handled across different tmt steps (cleanup, finish, prepare) by introducing a shared _guest_copies cached property in the base Step class. This centralizes the logic for creating guest copies and configuring them for step-specific operations, removing redundant code from individual step implementations. Additionally, a new is_running flag is added to the Queue class to track its active state, and the add_phase method in the base Step class is enhanced to dynamically enqueue phases into the queue if it's currently running. There is no feedback to provide on the review comments as none were provided.
This was referenced Mar 25, 2026
Contributor
Author
|
/packit build |
happz
force-pushed
the
step-add-phase-to-queue
branch
from
c30e6c8 to
18e7d59
Compare
LecrisUT
approved these changes
Mar 27, 2026
happz
force-pushed
the
step-with-queue
branch
3 times, most recently
from
445e4a3 to
ab7c95e
Compare
AthreyVinay
reviewed
Mar 30, 2026
happz
force-pushed
the
step-add-phase-to-queue
branch
from
18e7d59 to
e6a1189
Compare
happz
force-pushed
the
step-add-phase-to-queue
branch
from
e6a1189 to
a84be31
Compare
AthreyVinay
approved these changes
Mar 30, 2026
happz
force-pushed
the
step-add-phase-to-queue
branch
from
1d33b15 to
e6b3d7b
Compare
therazix
approved these changes
Apr 1, 2026
happz
force-pushed
the
step-add-phase-to-queue
branch
from
0ddd54e to
49b6bd2
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
If the queue is running, phases is added there. If the queue is not running, we shall not touch the queue: it's either already done, or it will start at some point in the future, in which case step would add the phase just as any other "static" phase.
happz
force-pushed
the
step-add-phase-to-queue
branch
from
e59f5fb to
6fd141c
Compare
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
psss
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the queue is running, phases is added there. If the queue is not running, we shall not touch the queue: it's either already done, or it will start at some point in the future, in which case step would add the phase just as any other "static" phase.
Pull Request Checklist