Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implement InterswitchGateway (Nigeria - Quickteller/Webpay) #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: implement InterswitchGateway (Nigeria - Quickteller/Webpay) #28
Changes from all commits
3c51bccc2f6613d69dd9a35a5d64388f492File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: teesofttech/PayBridge
Length of output: 6282
Fix
InterswitchGatewayregistration soPaymentServicecan resolve it viaIEnumerable<IPaymentGateway>PaymentServiceinjectsIEnumerable<IPaymentGateway>and builds_gatewayswithgateways.ToDictionary(g => g.GatewayType), butInterswitchGatewayis only registered as the concrete type (services.AddScoped<InterswitchGateway>();) in both the default path (line 140) andcase PaymentGatewayType.Interswitch(178-180). Unlike other gateways, it is not also registered asIPaymentGateway, soPaymentGatewayType.Interswitchwon’t be present inPaymentService’s gateway map.Suggested fix
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validate
PaymentItemCodein constructor like other required credentials.CreatePaymentAsyncalways sendspayableCode; allowing empty config here shifts a deterministic misconfiguration into runtime API failures.Suggested fix
if (string.IsNullOrEmpty(_config.Interswitch.MerchantCode)) throw new InvalidOperationException("Interswitch MerchantCode is required"); +if (string.IsNullOrEmpty(_config.Interswitch.PaymentItemCode)) + throw new InvalidOperationException("Interswitch PaymentItemCode is required");📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use rounded checked conversion for kobo amounts.
Direct
(int)(amount * 100)truncates fractional values and can overflow. That can send wrong amounts to the gateway.Suggested fix
Also applies to: 261-262
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.