Skip to content

chore: trim duplicate sample projects#35

Closed
teesofttech wants to merge 1 commit into
masterfrom
codex/trim-sample-projects
Closed

chore: trim duplicate sample projects#35
teesofttech wants to merge 1 commit into
masterfrom
codex/trim-sample-projects

Conversation

@teesofttech

@teesofttech teesofttech commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the Aspire AppHost and ServiceDefaults projects
  • remove the duplicate MVC sample project
  • keep the focused console examples project as the single sample surface
  • update the solution to contain only the SDK, tests, and examples

Validation

  • dotnet build TableauSharp.sln
  • dotnet test TableauSharp.sln --no-build

Notes

  • .DS_Store remains unstaged and is not part of this PR.

Summary by CodeRabbit

  • Chores
    • Removed the AppHost project and sample application from the solution, along with associated service defaults infrastructure.
    • Removed supporting configuration files, launch settings, and UI assets.
    • Simplified the project structure to focus on the core library.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 270452c4-cb41-4c39-8e37-ddd4369c4514

📥 Commits

Reviewing files that changed from the base of the PR and between 43f331f and 704ac0b.

⛔ Files ignored due to path filters (53)
  • TableauSharp.Sample/wwwroot/favicon.ico is excluded by !**/*.ico
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.rtl.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.rtl.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.rtl.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-grid.rtl.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.rtl.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.rtl.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.rtl.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.rtl.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.rtl.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.rtl.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.rtl.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap-utilities.rtl.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.rtl.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.rtl.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.rtl.min.css is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/css/bootstrap.rtl.min.css.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.js is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.js.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.min.js is excluded by !**/dist/**, !**/*.min.js
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.min.js.map is excluded by !**/dist/**, !**/*.map, !**/*.min.js.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.esm.js is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.esm.js.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.esm.min.js is excluded by !**/dist/**, !**/*.min.js
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.esm.min.js.map is excluded by !**/dist/**, !**/*.map, !**/*.min.js.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.js is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.js.map is excluded by !**/dist/**, !**/*.map
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.min.js is excluded by !**/dist/**, !**/*.min.js
  • TableauSharp.Sample/wwwroot/lib/bootstrap/dist/js/bootstrap.min.js.map is excluded by !**/dist/**, !**/*.map, !**/*.min.js.map
  • TableauSharp.Sample/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js is excluded by !**/*.min.js
  • TableauSharp.Sample/wwwroot/lib/jquery-validation/dist/additional-methods.js is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/jquery-validation/dist/additional-methods.min.js is excluded by !**/dist/**, !**/*.min.js
  • TableauSharp.Sample/wwwroot/lib/jquery-validation/dist/jquery.validate.js is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/jquery-validation/dist/jquery.validate.min.js is excluded by !**/dist/**, !**/*.min.js
  • TableauSharp.Sample/wwwroot/lib/jquery/dist/jquery.js is excluded by !**/dist/**
  • TableauSharp.Sample/wwwroot/lib/jquery/dist/jquery.min.js is excluded by !**/dist/**, !**/*.min.js
  • TableauSharp.Sample/wwwroot/lib/jquery/dist/jquery.min.map is excluded by !**/dist/**, !**/*.map
📒 Files selected for processing (30)
  • TableauSharp.AppHost/Program.cs
  • TableauSharp.AppHost/Properties/launchSettings.json
  • TableauSharp.AppHost/TableauSharp.AppHost.csproj
  • TableauSharp.AppHost/appsettings.Development.json
  • TableauSharp.AppHost/appsettings.json
  • TableauSharp.Sample/Controllers/HomeController.cs
  • TableauSharp.Sample/Models/ErrorViewModel.cs
  • TableauSharp.Sample/Program.cs
  • TableauSharp.Sample/Properties/launchSettings.json
  • TableauSharp.Sample/TableauSharp.Sample.csproj
  • TableauSharp.Sample/Views/Home/Index.cshtml
  • TableauSharp.Sample/Views/Home/Privacy.cshtml
  • TableauSharp.Sample/Views/Shared/Error.cshtml
  • TableauSharp.Sample/Views/Shared/_Layout.cshtml
  • TableauSharp.Sample/Views/Shared/_Layout.cshtml.css
  • TableauSharp.Sample/Views/Shared/_ValidationScriptsPartial.cshtml
  • TableauSharp.Sample/Views/_ViewImports.cshtml
  • TableauSharp.Sample/Views/_ViewStart.cshtml
  • TableauSharp.Sample/appsettings.Development.json
  • TableauSharp.Sample/appsettings.json
  • TableauSharp.Sample/wwwroot/css/site.css
  • TableauSharp.Sample/wwwroot/js/site.js
  • TableauSharp.Sample/wwwroot/lib/bootstrap/LICENSE
  • TableauSharp.Sample/wwwroot/lib/jquery-validation-unobtrusive/LICENSE.txt
  • TableauSharp.Sample/wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
  • TableauSharp.Sample/wwwroot/lib/jquery-validation/LICENSE.md
  • TableauSharp.Sample/wwwroot/lib/jquery/LICENSE.txt
  • TableauSharp.ServiceDefaults/Extensions.cs
  • TableauSharp.ServiceDefaults/TableauSharp.ServiceDefaults.csproj
  • TableauSharp.sln

📝 Walkthrough

Walkthrough

Removes the TableauSharp.Sample, TableauSharp.AppHost, and TableauSharp.ServiceDefaults projects entirely, deleting all source files, configuration files, views, static assets, and project definitions. The solution file is updated to deregister those three projects and remap TableauSharp.Examples under the samples solution folder.

Changes

Project removal and solution update

Layer / File(s) Summary
Solution file cleanup
TableauSharp.sln
Removes project entries for TableauSharp.Sample, TableauSharp.AppHost, and TableauSharp.ServiceDefaults; strips their build configuration platform entries; and updates NestedProjects to map TableauSharp.Examples under the samples folder.
AppHost project deletion
TableauSharp.AppHost/TableauSharp.AppHost.csproj, TableauSharp.AppHost/Program.cs, TableauSharp.AppHost/Properties/launchSettings.json, TableauSharp.AppHost/appsettings*.json
Removes the Aspire AppHost project including its Program.cs startup logic, launch profiles, appsettings, and .csproj referencing Aspire.AppHost.Sdk and Aspire.Hosting.AppHost v9.2.1.
ServiceDefaults project deletion
TableauSharp.ServiceDefaults/Extensions.cs, TableauSharp.ServiceDefaults/TableauSharp.ServiceDefaults.csproj
Removes the shared service defaults library, including the Extensions static class (OpenTelemetry configuration, health checks, service discovery, MapDefaultEndpoints) and the .csproj with OpenTelemetry/HTTP resilience package references.
Sample application code and config deletion
TableauSharp.Sample/Program.cs, TableauSharp.Sample/Controllers/HomeController.cs, TableauSharp.Sample/Models/ErrorViewModel.cs, TableauSharp.Sample/TableauSharp.Sample.csproj, TableauSharp.Sample/appsettings*.json, TableauSharp.Sample/Properties/launchSettings.json
Removes the MVC web application startup, HomeController (with JWT sign-in via IAuthService), ErrorViewModel, project file, all appsettings, and launch profiles.
Sample views and static assets deletion
TableauSharp.Sample/Views/..., TableauSharp.Sample/wwwroot/...
Removes all Razor views (Index, Privacy, Error, _Layout, _ViewImports, _ViewStart, _ValidationScriptsPartial), associated CSS/JS, and third-party library files (Bootstrap, jQuery, jquery-validation-unobtrusive).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • teesofttech/TableauSharp#19: Introduces TableauSharp.Examples and wires it into the solution — the counterpart to this PR which removes the old TableauSharp.Sample and related infrastructure projects.

Poem

🐇 Hop, hop, away with the old!
Three projects deleted, the story is told.
AppHost and Sample and ServiceDefaults too,
All swept from the .sln, fresh start anew.
Examples shall rise where the scaffolding fell —
A cleaner solution, oh isn't it swell? ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/trim-sample-projects

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@teesofttech
teesofttech marked this pull request as ready for review June 14, 2026 16:19
Copilot AI review requested due to automatic review settings June 14, 2026 16:19
@teesofttech
teesofttech deleted the codex/trim-sample-projects branch June 14, 2026 16:19
@teesofttech teesofttech changed the title [codex] trim duplicate sample projects chore: trim duplicate sample projects Jun 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants