use collaborators/.../permission to infer reviewer permissions - #185
Merged
Conversation
seems like the term collaborators is overloaded in the github-api.
As it seems collaborators/${user} only returns 204 if the user has at
least maintainer permissions. I expected it returns 204 whenever the
user is somehow still collaborating in the sense of it is still in the
list of collaborators in the repo settings somehow (directly or
indirectly via teams or implicitly via org etc.)
so for a user with write permissions collaborators/${user} returned 404
where collaborators/${user}/permission returns 200 -- nice design GitHub
Member
Author
|
this should trigger an Auto-Cleanup PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems like the term collaborators is overloaded in the github-api. As it seems collaborators/${user} only returns 204 if the user has at least maintainer permissions. I expected it returns 204 whenever the user is somehow still collaborating in the sense of it is still in the list of collaborators in the repo settings somehow (directly or indirectly via teams or implicitly via org etc.)
so for a user with write permissions collaborators/${user} returned 404 where collaborators/${user}/permission returns 200 -- nice design GitHub
I confirm that I have read the Contributor Agreement v1.1, agree to be bound on them and confirm that my contribution is compliant.