fix(signing): make KMS OIDC fallback test environment-independent - #1765
Merged
Conversation
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Member
|
/cherry-pick release-v0.28.x |
|
✅ Cherry-pick to A new pull request has been created to cherry-pick this change to PR: #1767 Please review and merge the cherry-pick PR. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix
TestOIDCTokenFallbackToDefaultPathfailing in the release pipeline while passing locally.Problem
The test verifies that when
oidc.pathandoidc.roleare configuredbut no explicit
tokenPathis given,NewSignerfalls back to thedefault Kubernetes service account token path
(
/var/run/secrets/kubernetes.io/serviceaccount/token) and errorsbecause the file doesn't exist.
On developer machines this works, but in the release pipeline the tests
run inside a Kubernetes pod where that file does exist (auto-mounted
by K8s). So
os.ReadFilesucceeds, the OIDC block completes, and theerror surfaces later from
kms.Get()with an emptyKMSRef:This doesn't match the test's
assert.Containschecks for"reading OIDC token", causing the failure.Fix
defaultOIDCTokenPathfromconsttovar(unexported, noAPI impact) so tests can override it.
t.TempDir() + "/nonexistent-sa-token"—a path guaranteed not to exist in any environment — and restore the
original via
t.Cleanup.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/kind bug