WIP Update to allow for multiple backend selections

[pxp928]

Changes made to allow for multiple backend to be selected. If none are selected, that artifact is disabled. Work in progress. Tests need to be altered or rewritten based on how the solution is implemented.

Issue #279 and #288

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mpeters
You can assign the PR to them by writing /assign @mpeters in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

Hi @pxp928. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[priyawadhwa]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	69.4%	67.6%	-1.9
pkg/chains/storage/storage.go	33.3%	40.9%	7.6
pkg/config/config.go	88.6%	64.6%	-24.0

[priyawadhwa]

I'm rethinking having a separate key for each backend now that I see it 🤔

It might be difficult to keep the config organized. The advantage of a comma-separated list is that it would be backwards compatible as well.

WDYT of doing that instead?

artifacts.oci.storage=tekton,gcs

and then if the value is empty artifacts.oci.storage="" then we assume that we don't want to store anything at all (which would address the issue in #279 as well)

[pxp928]

Yes I agree. The config does get very cluttered. Having a comma-separated would be the better way to go. Plus it would also require less unit test updates. Let me change to using that and I will re-push on this branch.

[priyawadhwa]

thank you! we can keep the defaults as they are as well that way :)

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	69.4%	67.6%	-1.9
pkg/chains/storage/storage.go	33.3%	40.9%	7.6
pkg/config/config.go	88.6%	69.4%	-19.2

[tekton-robot]

@pxp928: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-chains-unit-tests	839b312	link	/test pull-tekton-chains-unit-tests
pull-tekton-chains-build-tests	839b312	link	/test pull-tekton-chains-build-tests
pull-tekton-chains-integration-tests	839b312	link	/test pull-tekton-chains-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.