added multi-backend support

[pxp928]

Changes made to allow for multiple backend to be selected. If none are selected, that artifact is disabled. Work in progress. Tests need to be altered or rewritten based on how the solution is implemented. Continuation of PR #297

Issue #279 and #288

[tekton-robot]

Hi @pxp928. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[priyawadhwa]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	69.4%	67.6%	-1.9
pkg/chains/signing.go	79.2%	79.6%	0.4
pkg/chains/storage/storage.go	33.3%	45.5%	12.1
pkg/config/config.go	88.6%	90.0%	1.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	69.4%	67.6%	-1.9
pkg/chains/signing.go	79.2%	79.6%	0.4
pkg/chains/storage/storage.go	33.3%	45.5%	12.1
pkg/config/config.go	88.6%	90.0%	1.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	69.4%	67.6%	-1.9
pkg/chains/signing.go	79.2%	79.6%	0.4
pkg/chains/storage/storage.go	33.3%	45.5%	12.1
pkg/config/config.go	88.6%	90.0%	1.4

[priyawadhwa]

Just a few nits! Would you mind adding an integration test to check for mulitple backends as well?

You could copy TestOCIStorage but also include tekton as a backend and verify both!

chains/test/e2e_test.go

Line 322 in a7e0557

func TestOCIStorage(t *testing.T) {

[pxp928]

Just a few nits! Would you mind adding an integration test to check for mulitple backends as well?

You could copy TestOCIStorage but also include tekton as a backend and verify both!

chains/test/e2e_test.go

Line 322 in a7e0557

func TestOCIStorage(t *testing.T) {

Added new integration test with OCI and tekton backend storage.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	69.4%	67.6%	-1.9
pkg/chains/signing.go	79.2%	78.8%	-0.4
pkg/chains/storage/storage.go	33.3%	45.5%	12.1
pkg/config/config.go	88.6%	89.8%	1.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	69.4%	67.6%	-1.9
pkg/chains/signing.go	79.2%	78.8%	-0.4
pkg/chains/storage/storage.go	33.3%	45.5%	12.1
pkg/config/config.go	88.6%	89.8%	1.2

[priyawadhwa]

this looks great! thanks @pxp928 for adding this awesome new feature 🎉

[priyawadhwa]

cc @rgreinho just an fyi since you've been working on this code!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[priyawadhwa]

/lgtm