Skip to content

getting rid of 'pipelien'#526

Merged
tekton-robot merged 2 commits into
tektoncd:mainfrom
ChaosInTheCRD:pipelien
Sep 1, 2022
Merged

getting rid of 'pipelien'#526
tekton-robot merged 2 commits into
tektoncd:mainfrom
ChaosInTheCRD:pipelien

Conversation

@ChaosInTheCRD

@ChaosInTheCRD ChaosInTheCRD commented Aug 22, 2022

Copy link
Copy Markdown

Signed-off-by: ChaosInTheCRD thomas.meadows@jetstack.io

Changes

Just found a typo in the codebase, getting rid of it.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

getting rid of 'pipelien'
9b0cb0f 
Signed-off-by: ChaosInTheCRD <thomas.meadows@jetstack.io>
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 22, 2022 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ChaosInTheCRD / name: Tom Meadows (9b0cb0f)

@tekton-robot

tekton-robot commented Aug 22, 2022

Copy link
Copy Markdown

Hi @ChaosInTheCRD. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2022
@wlynch

wlynch commented Aug 22, 2022

Copy link
Copy Markdown
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2022
wlynch
wlynch requested changes Aug 22, 2022
View reviewed changes
Comment thread vendor/github.com/tektoncd/pipeline/pkg/apis/config/metrics.go
// when it isn't specified in configmap
DefaultPipelinerunLevel = PipelinerunLevelAtPipeline
// PipelinerunLevelAtPipelinerun specify that aggregation will be done at
// pipelienrun level

@wlynch wlynch Aug 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is imported from https://github.com/tektoncd/pipeline - we'll need to make the change upstream and pull it in.

For this PR, you can revert this file.

@chuangw6 chuangw6 Aug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in pipeline tektoncd/pipeline#5382. Using same title ;)

@lcarva lcarva Aug 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want to revert the file, right? Anything under vendor will be updated on the next module update.

@ChaosInTheCRD ChaosInTheCRD Sep 1, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing 🙂

@ChaosInTheCRD ChaosInTheCRD Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated - would be good if I could get a re-review @wlynch

@tekton-robot

tekton-robot commented Aug 22, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@priyawadhwa

priyawadhwa commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@priyawadhwa priyawadhwa removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
Yongxuanzhang
Yongxuanzhang reviewed Aug 25, 2022
View reviewed changes

@Yongxuanzhang Yongxuanzhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for fixing this! I agree with Billy's comments!

@tekton-robot

tekton-robot commented Aug 25, 2022

Copy link
Copy Markdown

@Yongxuanzhang: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
Thanks for fixing this! I agree with Billy's comments!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

reverting vendored file back to upstream
a40268a 
Signed-off-by: ChaosInTheCRD <thomas.meadows@jetstack.io>
@ChaosInTheCRD ChaosInTheCRD requested review from wlynch and removed request for dlorenc and mattmoor September 1, 2022 13:58
@lcarva

lcarva commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@tekton-robot tekton-robot merged commit 36d1551 into tektoncd:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcarva lcarva lcarva left review comments
@priyawadhwa priyawadhwa priyawadhwa approved these changes
@wlynch wlynch Awaiting requested review from wlynch
+2 more reviewers
@chuangw6 chuangw6 chuangw6 left review comments
@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@lcarva lcarva

@priyawadhwa priyawadhwa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ChaosInTheCRD @tekton-robot @wlynch @priyawadhwa @lcarva @chuangw6 @Yongxuanzhang