Skip to content

Issue 642: Add sidecar, step and remote tasks to pipelinerun materials#658

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
chitrangpatel:add-materials-to-pipelinerun
Jan 17, 2023
Merged

Issue 642: Add sidecar, step and remote tasks to pipelinerun materials#658
tekton-robot merged 1 commit into
tektoncd:mainfrom
chitrangpatel:add-materials-to-pipelinerun

Conversation

@chitrangpatel

@chitrangpatel chitrangpatel commented Dec 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR addresses issue #642 by adding steps and sidecars image uri and digest information to predicate.materials for a PipelineRun.

Prior to reviewing this PR, review #649

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

predicate.materials includes image uri and digest information from all steps, sidecars and also config source information for remote tasks.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 22, 2022
@chitrangpatel

chitrangpatel commented Dec 22, 2022

Copy link
Copy Markdown
Contributor Author

/hold merge #649 first

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2022
@tekton-robot

tekton-robot commented Dec 22, 2022

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 75.9% -3.3
pkg/chains/formats/intotoite6/taskrun/material.go Do not exist 83.5%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 76.7% 62.5% -14.2

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 4d33475 to f093dd7 Compare December 22, 2022 16:24
@chitrangpatel chitrangpatel mentioned this pull request Dec 22, 2022
Merged
6 tasks
@tekton-robot

tekton-robot commented Dec 22, 2022

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1
pkg/chains/formats/intotoite6/taskrun/material.go Do not exist 83.5%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 76.7% 62.5% -14.2

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch 2 times, most recently from a5ce2f3 to 6d9e56b Compare December 22, 2022 18:58
@tekton-robot

tekton-robot commented Dec 22, 2022

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1
pkg/chains/formats/intotoite6/taskrun/material.go Do not exist 84.1%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 76.7% 62.5% -14.2

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 6d9e56b to 6e10fba Compare December 22, 2022 19:05
@tekton-robot

tekton-robot commented Dec 22, 2022

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1
pkg/chains/formats/intotoite6/taskrun/material.go Do not exist 84.1%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 76.7% 62.5% -14.2

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 6e10fba to 40f59d9 Compare December 22, 2022 19:25
@tekton-robot

tekton-robot commented Dec 22, 2022

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1
pkg/chains/formats/intotoite6/taskrun/material.go Do not exist 84.1%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 76.7% 62.5% -14.2

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 40f59d9 to d1fbd03 Compare December 22, 2022 19:43
@tekton-robot

tekton-robot commented Dec 22, 2022

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1
pkg/chains/formats/intotoite6/taskrun/material.go Do not exist 84.1%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 76.7% 62.5% -14.2

@chitrangpatel chitrangpatel changed the title Add materials to pipelinerun Issue 642: Add materials to pipelinerun Jan 3, 2023
@chitrangpatel chitrangpatel changed the title Issue 642: Add materials to pipelinerun Issue 642: Add more materials to pipelinerun Jan 3, 2023
@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from d1fbd03 to 67e3722 Compare January 9, 2023 19:23
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2023
@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 67e3722 to 1abe71a Compare January 9, 2023 19:29
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2023
@chitrangpatel

chitrangpatel commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2023
@tekton-robot

tekton-robot commented Jan 9, 2023

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1
pkg/chains/formats/intotoite6/taskrun/material.go 83.3% 84.1% 0.8

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch 2 times, most recently from 2579623 to e3bdcc8 Compare January 11, 2023 17:25
@tekton-robot

tekton-robot commented Jan 11, 2023

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1

@chitrangpatel chitrangpatel changed the title Issue 642: Add more materials to pipelinerun Issue 642: Add sidecar, step and remote tasks to pipelinerun materials Jan 11, 2023
@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from e3bdcc8 to d226ba3 Compare January 12, 2023 18:01
@tekton-robot

tekton-robot commented Jan 12, 2023

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from d226ba3 to 184b3c7 Compare January 12, 2023 18:47
@tekton-robot

tekton-robot commented Jan 12, 2023

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1

@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 184b3c7 to 523f904 Compare January 13, 2023 16:03
@tekton-robot

tekton-robot commented Jan 13, 2023

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.2% 76.1% -3.1

lcarva
lcarva reviewed Jan 13, 2023
View reviewed changes
Comment thread pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go
@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 523f904 to 00149b6 Compare January 17, 2023 18:41
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2023
@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch 2 times, most recently from 0ae2c33 to 4365783 Compare January 17, 2023 18:47
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2023
@chitrangpatel
Issue 642: predicate.materials needs to record more information in Pi…
96c74ec 
…pelineRun

This PR addresses issue tektoncd#642 by adding steps and sidecars image uri and digest information to predicate.materials for a PipelineRun. In addition, the configSource information for the remote tasks and the pipeline are also added.
@chitrangpatel chitrangpatel force-pushed the add-materials-to-pipelinerun branch from 4365783 to 96c74ec Compare January 17, 2023 19:11
@tekton-robot

tekton-robot commented Jan 17, 2023

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go 79.4% 76.9% -2.5

lcarva
lcarva approved these changes Jan 17, 2023
View reviewed changes

@lcarva lcarva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@tekton-robot

tekton-robot commented Jan 17, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@tekton-robot tekton-robot merged commit 28a6c69 into tektoncd:main Jan 17, 2023
This was referenced Jan 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcarva lcarva lcarva approved these changes
@chuangw6 chuangw6 Awaiting requested review from chuangw6
@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees

@lcarva lcarva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chitrangpatel @tekton-robot @lcarva