Issue 642: predicate.materials needs to record more information in TaskRun#649
Merged
tekton-robot merged 1 commit intoJan 9, 2023
Conversation
tekton-robot
added
the
size/XL
Contributor
Author
|
/kind bug |
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
5871209 to
40955d1
Compare
|
The following is the coverage report on the affected files.
|
chuangw6
reviewed
Dec 19, 2022
wlynch
requested changes
Dec 19, 2022
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
67d312e to
1e0a3c3
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
1e0a3c3 to
8cd6294
Compare
tekton-robot
added
size/XXL
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
8cd6294 to
645f946
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
645f946 to
b123506
Compare
tekton-robot
added
size/XL
|
The following is the coverage report on the affected files.
|
Contributor
Author
|
/retest |
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
b123506 to
fa40296
Compare
tekton-robot
added
size/XXL
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
fa40296 to
fbf249e
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
fbf249e to
96220a2
Compare
|
The following is the coverage report on the affected files.
|
Contributor
Author
|
/retest |
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
96220a2 to
8d0d9e9
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
8d0d9e9 to
cf79e26
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
cf79e26 to
a3b75a9
Compare
6 tasks
|
The following is the coverage report on the affected files.
|
wlynch
requested changes
Dec 22, 2022
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
a3b75a9 to
3c06a56
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
3c06a56 to
da5d864
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
da5d864 to
f8c9604
Compare
This PR addressed issue tektoncd#642 by adding step and sidecar image uri and digest information to `predicate.materials` for a `TaskRun`. A follow-up PR will be created to address materials for `PipelineRun`.
chitrangpatel
force-pushed
the
add-step-sidecar-image-details-in-predicate-material
branch
from
f8c9604 to
d326d90
Compare
|
The following is the coverage report on the affected files.
|
wlynch
requested changes
Jan 9, 2023
Comment on lines
+39
to
+59
| func AddStepImagesToMaterials(steps []v1beta1.StepState, mats *[]slsa.ProvenanceMaterial) error { | ||
| for _, stepState := range steps { | ||
| if err := AddImageIDToMaterials(stepState.ImageID, mats); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // AddSidecarImagesToMaterials adds sidecar images to predicate.materials | ||
| func AddSidecarImagesToMaterials(sidecars []v1beta1.SidecarState, mats *[]slsa.ProvenanceMaterial) error { | ||
| for _, sidecarState := range sidecars { | ||
| if err := AddImageIDToMaterials(sidecarState.ImageID, mats); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // AddImageIDToMaterials converts an imageId with format <uri>@sha256:<digest> and then adds it to a provenance materials. | ||
| func AddImageIDToMaterials(imageID string, mats *[]slsa.ProvenanceMaterial) error { |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This was referenced Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #642 by adding
stepsandsidecarsimage uri and digest information topredicate.materialsfor aTaskRun. Predicate.materials forPipelineRunare addressed in #658.Changes
materialswas pulled out fromtaskrun.gointo its own module likebuildconfig.go:material.goimageIDofstepsandsidecarsoftaskrunobject.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes