Unexport intoto/taskrun funcs#668
Merged
Merged
Conversation
These funcs do not need to be exported.
tekton-robot
added
the
size/S
chitrangpatel
approved these changes
Jan 9, 2023
chitrangpatel
left a comment
chitrangpatel
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I think this is fine for now. I do think that these will have to be exported when I implement TEP0122 like provenance. The materials there will be the same as here so it can be reused. I'm happy to export it then to keep it clean.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
These funcs do not need to be exported, so unexporting them for now.
Snuck in from #649
cc @chitrangpatel
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes