Skip to content

[release-v0.37.x] CI: Use goinstall mode for golangci-lint action - #2990

Merged
vdemeester merged 1 commit into
tektoncd:release-v0.37.xfrom
vdemeester:fix/golangci-lint-goinstall-release-v0.37.x
Jul 7, 2026
Merged

[release-v0.37.x] CI: Use goinstall mode for golangci-lint action#2990
vdemeester merged 1 commit into
tektoncd:release-v0.37.xfrom
vdemeester:fix/golangci-lint-goinstall-release-v0.37.x

Conversation

@vdemeester

Copy link
Copy Markdown
Member

Changes

Cherry-pick of #2984 to release-v0.37.x.

The prebuilt golangci-lint binary was built with Go 1.25, which is incompatible with our Go 1.26 toolchain. Switch to install-mode: goinstall so golangci-lint is compiled from source using the project's Go version, avoiding the mismatch.

Submitter Checklist

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 3, 2026
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2026
@vdemeester vdemeester changed the title CI: Use goinstall mode for golangci-lint action [release-v0.37.x] CI: Use goinstall mode for golangci-lint action Jul 3, 2026
@waveywaves

Copy link
Copy Markdown
Member

/retest

The prebuilt golangci-lint binary was built with Go 1.25, which is
incompatible with our Go 1.26 toolchain. Switch to install-mode:
goinstall so golangci-lint is compiled from source using the project's
Go version, avoiding the mismatch.

Cherry-pick of fix from main to release-v0.37.x.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
vdemeester force-pushed the fix/golangci-lint-goinstall-release-v0.37.x branch from a0b13b2 to afda73a Compare July 6, 2026 09:57
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2026
@chmouel

chmouel commented Jul 6, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, divyansh42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@vdemeester
vdemeester merged commit 2a8aea5 into tektoncd:release-v0.37.x Jul 7, 2026
16 of 18 checks passed
@vdemeester
vdemeester deleted the fix/golangci-lint-goinstall-release-v0.37.x branch July 7, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants