[release-v0.37.x] cherry-pick: fix alibabacloud-go/cr-20160607 license - #3018
Merged
tekton-robot merged 1 commit intoJul 9, 2026
Conversation
Using a fork + replace, hopefully it will work ? Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
do-not-merge/release-note-label-needed
Member
Author
|
/release-note-none |
tekton-robot
added
release-note-none
divyansh42
changed the title
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Member
Author
|
/retest |
3 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainto fix the "Check generated code" CI failure onrelease-v0.37.xreplacedirective ingo.modto pointalibabacloud-go/cr-20160607tovdemeester/cr-20160607(a fork that includes the LICENSE file)hack/update-deps.shsince the fork handles itContext
alibabacloud-go/cr-20160607@v1.0.1ships without a LICENSE file. Onmain, this was fixed by replacing it with a fork. Onrelease-v0.37.x, a manual copy workaround inupdate-deps.shwas used instead, butgo mod vendorstrips these files, causing "Check generated code" failures whenever vendor is regenerated without running the fullupdate-deps.shscript.This cherry-pick aligns
release-v0.37.xwithmainby using the samereplacedirective approach.Made with Cursor