TEP-0114: Custom Tasks Beta - Retries#862
Conversation
tekton-robot
added
the
kind/tep
tekton-robot
added
needs-rebase
jerop
force-pushed
the
retries-custom-runs
branch
2 times, most recently
from
09313b9 to
39df178
Compare
tekton-robot
removed
the
needs-rebase
In [TEP-0121][tep-0121], we are redesigining `Retries` in `TaskRuns` and `CustomRuns`. In this change, we propose excluding `retries` and `retriesStatus` in the initial release of `CustomRuns`. We will figure out a way forward in [TEP-0121][tep-0121], which could be reintroducing the fields implementing replacement fields. This allows us to unblock release of Custom Tasks Beta and Tekton Pipelines V1. /kind tep [tep-0121]: tektoncd#816
jerop
force-pushed
the
retries-custom-runs
branch
from
39df178 to
10a46d4
Compare
|
/approve |
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Look good to me. Thanks for updating the TEP! |
Will be squashed once tektoncd/community#862 is merged Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
|
/lgtm |
|
@jerop @XinruZhang Thinking about this a bit more, migration from v1alpha1.Run to v1beta1.CustomRun is going to be really challenging if we remove v1alpha1.Run before resolving this problem. Users would have to introduce a custom retries field into their customRun spec, and then end up having to update again once/if we reintroduce retries into the spec. Maybe we should at least update the TEP to specify that we won't remove Runs or encourage people to migrate to CustomRuns until this is resolved? |
5 participants
In TEP-0121, we are redesigining
RetriesinTaskRunsandCustomRuns.In this change, we propose excluding
retriesandretriesStatusin the initial release ofCustomRuns.We will figure out a way forward in TEP-0121, which could be reintroducing the fields implementing replacement fields.
This allows us to unblock release of Custom Tasks Beta and Tekton Pipelines V1.
/kind tep
cc @abayer @lbernick @XinruZhang