Skip to content

Accessibility fix: avoid animation rotation#4982

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
kaushalnavneet:fix/avoid-spin-animation-accesibility
May 22, 2026
Merged

Accessibility fix: avoid animation rotation#4982
tekton-robot merged 1 commit into
tektoncd:mainfrom
kaushalnavneet:fix/avoid-spin-animation-accesibility

Conversation

@kaushalnavneet
Copy link
Copy Markdown
Contributor

@kaushalnavneet kaushalnavneet commented May 21, 2026

Changes

  • Disables rotating spinner animation when users have reduced motion preference enabled in their OS/browser settings.
  • This prevents discomfort for users with motion-triggered vestibular disorders.

Fixes #4974

/kind misc

Testing

Tested using Chrome DevTools → Command Palette → "Emulate CSS prefers-reduced-motion: reduce"

✅ Confirmed: Running status icon stops spinning when reduced motion is enabled
✅ Normal behavior: Spinner continues rotating when reduced motion is disabled

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2026
Copy link
Copy Markdown
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Navneet. 2 minor nits in the change, otherwise looks good.

Can you also update the commit message to include the info from the PR description, i.e. the purpose of the change? This makes it easier to understand changes when reviewing the git log without having to open the associated PRs too.

Comment thread packages/components/src/components/Spinner/_Spinner.scss Outdated
Comment thread packages/components/src/components/Spinner/_Spinner.scss Outdated
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
- Disables rotating spinner animation when users have reduced motion preference enabled in their OS/browser settings
- This prevents discomfort for users with motion-triggered vestibular disorders
@kaushalnavneet kaushalnavneet force-pushed the fix/avoid-spin-animation-accesibility branch from 1bc3ea0 to b2649c7 Compare May 22, 2026 12:51
Copy link
Copy Markdown
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2026
@tekton-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 0e6092a into tektoncd:main May 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid rotating animations for users with reduced motion preference

3 participants