fix(deps): bump sigstore-go with knative.dev/pkg semconv alignment - #3785
Conversation
Bumps [github.com/sigstore/sigstore-go](https://github.com/sigstore/sigstore-go) from 1.1.4 to 1.2.0. - [Release notes](https://github.com/sigstore/sigstore-go/releases) - [Commits](sigstore/sigstore-go@v1.1.4...v1.2.0) --- updated-dependencies: - dependency-name: github.com/sigstore/sigstore-go dependency-version: 1.2.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
The sigstore-go v1.2.0 bump transitively requires
go.opentelemetry.io/otel/sdk v1.44.0, which uses semconv/v1.41.0.
The previously vendored knative.dev/pkg (May 31 snapshot) uses
semconv/v1.40.0. At startup, knative's
observability/resource.Default() merges OTel resources with
conflicting schema URLs and panics:
panic: conflicting Schema URL:
https://opentelemetry.io/schemas/1.41.0
and https://opentelemetry.io/schemas/1.40.0
Bump knative.dev/pkg to the June 22 snapshot which uses
semconv/v1.41.0, aligning both sides of the resource.Merge() call.
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3785 +/- ##
==========================================
- Coverage 25.51% 25.47% -0.05%
==========================================
Files 448 449 +1
Lines 23309 23382 +73
==========================================
+ Hits 5948 5956 +8
- Misses 16675 16735 +60
- Partials 686 691 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/hold |
|
That pipeline PR's merged now @jkhelil . We can proceed to merging this as well. |
|
/approve |
|
/cancel hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold cancel |
Changes
Replacement for #3692.
Incorporates the
sigstore-gov1.1.4→v1.2.0 bump from #3692 andfixes the resulting startup panic by bumping
knative.dev/pkg.The
sigstore-gobump transitively requiresgo.opentelemetry.io/otel/sdkv1.44.0, which usessemconv/v1.41.0.The previously vendored
knative.dev/pkg(May 31 snapshot) usessemconv/v1.40.0. At startup,resource.Merge()hits conflictingschema URLs and panics (exit code 2, CrashLoopBackOff on operator
and webhook pods).
Fix: Bump
knative.dev/pkgto the June 22 snapshot(
v0.0.0-20260622140654-39ebae2ee2dc) which usessemconv/v1.41.0.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes