Skip to content

fix(deps): bump sigstore-go with knative.dev/pkg semconv alignment - #3785

Merged
tekton-robot merged 2 commits into
tektoncd:mainfrom
infernus01:fix/sigstore-go-bump-with-knative-alignment
Jul 23, 2026
Merged

fix(deps): bump sigstore-go with knative.dev/pkg semconv alignment#3785
tekton-robot merged 2 commits into
tektoncd:mainfrom
infernus01:fix/sigstore-go-bump-with-knative-alignment

Conversation

@infernus01

Copy link
Copy Markdown
Member

Changes

Replacement for #3692.

Incorporates the sigstore-go v1.1.4→v1.2.0 bump from #3692 and
fixes the resulting startup panic by bumping knative.dev/pkg.

The sigstore-go bump transitively requires
go.opentelemetry.io/otel/sdk v1.44.0, which uses semconv/v1.41.0.
The previously vendored knative.dev/pkg (May 31 snapshot) uses
semconv/v1.40.0. At startup, resource.Merge() hits conflicting
schema URLs and panics (exit code 2, CrashLoopBackOff on operator
and webhook pods).

Fix: Bump knative.dev/pkg to the June 22 snapshot
(v0.0.0-20260622140654-39ebae2ee2dc) which uses semconv/v1.41.0.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

dependabot Bot and others added 2 commits July 13, 2026 12:13
Bumps [github.com/sigstore/sigstore-go](https://github.com/sigstore/sigstore-go) from 1.1.4 to 1.2.0.
- [Release notes](https://github.com/sigstore/sigstore-go/releases)
- [Commits](sigstore/sigstore-go@v1.1.4...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/sigstore/sigstore-go
  dependency-version: 1.2.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
  The sigstore-go v1.2.0 bump transitively requires
  go.opentelemetry.io/otel/sdk v1.44.0, which uses semconv/v1.41.0.
  The previously vendored knative.dev/pkg (May 31 snapshot) uses
  semconv/v1.40.0. At startup, knative's
  observability/resource.Default() merges OTel resources with
  conflicting schema URLs and panics:

    panic: conflicting Schema URL:
      https://opentelemetry.io/schemas/1.41.0
      and https://opentelemetry.io/schemas/1.40.0

  Bump knative.dev/pkg to the June 22 snapshot which uses
  semconv/v1.41.0, aligning both sides of the resource.Merge() call.

Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 21, 2026

@infernus01 infernus01 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 21, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.47%. Comparing base (6a356d3) to head (aba3d6b).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3785      +/-   ##
==========================================
- Coverage   25.51%   25.47%   -0.05%     
==========================================
  Files         448      449       +1     
  Lines       23309    23382      +73     
==========================================
+ Hits         5948     5956       +8     
- Misses      16675    16735      +60     
- Partials      686      691       +5     
Flag Coverage Δ
unit-tests 25.47% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkhelil

jkhelil commented Jul 22, 2026

Copy link
Copy Markdown
Member

/hold
Merge Once Pipeline PR is merged tektoncd/pipeline#10447

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2026
@infernus01

Copy link
Copy Markdown
Member Author

That pipeline PR's merged now @jkhelil . We can proceed to merging this as well.

@jkhelil

jkhelil commented Jul 23, 2026

Copy link
Copy Markdown
Member

/approve

@jkhelil

jkhelil commented Jul 23, 2026

Copy link
Copy Markdown
Member

/cancel hold

@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@jkhelil

jkhelil commented Jul 23, 2026

Copy link
Copy Markdown
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@jkhelil

jkhelil commented Jul 23, 2026

Copy link
Copy Markdown
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2026
@tekton-robot
tekton-robot merged commit eb745ea into tektoncd:main Jul 23, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants