-
Notifications
You must be signed in to change notification settings - Fork 91
Amend null processing for NGSI-LD #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If an NGSI-LD value is sent with a null attribute, remove it from the NGSI-LD payload.
|
Related to FIWARE/context.Orion-LD#919 For Orion-LD and the following workaround: "value": {
"@type": "Intangible",
"@value": null
}It is causing inconsistency between brokers. So it looks like this phrase will be tightened up, so the existing resolved to a
I suggested to @Neeraj-Nec and @naveennec that a PR could be raised to deal with this. The fix is simple - if an NGSI-LD attribute value is parsed as |
| const context = { | ||
| op: 'IoTAgentNGSI.Entities-LD' | ||
| }; | ||
| const NGSIv2 = require('./entities-NGSI-v2'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry in CHANGES_NEXT_RELEASE file about the fix/change done in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 93a9686
| "prettier --parser markdown --tab-width 4 --print-width 120 --write --prose-wrap always", | ||
| "git add" | ||
| "prettier --parser markdown --tab-width 4 --print-width 120 --write --prose-wrap always" | ||
| ], | ||
| "*.js": [ | ||
| "prettier --config .prettierrc.json --write", | ||
| "git add" | ||
| "prettier --config .prettierrc.json --write" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate in this change, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since lint-staged@10.0.0 you can omit git add in the config - see https://github.com/okonet/lint-staged#v10
From v10.0.0 onwards any new modifications to originally staged files will be automatically added to the commit. If your task previously contained a git add step, please remove this. The automatic behaviour ensures there are less race-conditions, since trying to run multiple git operations at the same time usually results in an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. NTC
fgalan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If an NGSI-LD value is sent with a null attribute, remove it from the NGSI-LD payload.