feat: component ProgressBar - add optional input property 'percentage_start'#1204
Merged
acstll merged 4 commits intotelekom:mainfrom Sep 27, 2022
Merged
Conversation
acstll
requested changes
Sep 22, 2022
Collaborator
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
Thanks a lot @michael-koeller — sorry for the delay in the reply!
acstll
requested changes
Sep 27, 2022
Collaborator
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
I think you also need to update the snapshots (e.g. yarn test --spec --updateSnapshot in packages/components) — thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Request:
Property 'percentage_start' at component
<scale-progress-bar>Context
We are working on a Telekom-internal project. We just startet an new UI application for the TROPOS team, using this really great component library.
Use Case
We have a web page displaying a multi-step, partly-manual/partly-automated processing status. Our UI will keep polliing this page to reflect any server-side status changes. In this scenario it's quite annoying that the progress bar would alway restart it's animation from scratch.
Instead, we would rather set the previous percentage and thus only have nice animations on actual status changes.