Rating stars refactor + sketch generated stars#449
Merged
Conversation
oddcelot
force-pushed
the
refactor/rating-stars
branch
from
1246431 to
e4169fa
Compare
|
Your Render PR Server URL is https://scale-storybook-staging-pr-449.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c494q8k6fj33r8n5sl80. |
|
Your Render PR Server URL is https://scale-storybook-staging-pr-449.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c49ct6c6fj33r8n670g0. |
oddcelot
force-pushed
the
refactor/rating-stars
branch
from
437136a to
a53258f
Compare
acstll
reviewed
Aug 11, 2021
Collaborator
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
Looks good to merge. We need to wait for a11y approval before we merge this, so we could close this and re-open when the time comes.
Would it be possible to separate the "sketch" part in a different PR, or is it too closely related?
- staging server - badge (new) - s3 pipeline removed
* refactor: accessibility title structure * refactor: accessibility titles and roles * feat: link storie with accessibility
also make the whole thing more modular with parts
removes handmade version and replaces them with the the generated version
reosolves CodeQL report
oddcelot
force-pushed
the
refactor/rating-stars
branch
from
f5d5a1c to
0bd61da
Compare
Collaborator
|
Exceptionally merging before getting the a11y feedback to save us some trouble in the future 😑 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.