fix(inbox): one document rendering for all text-only items, GFM tables, 18px - #329
Merged
Conversation
Any { text } context now renders as the unboxed full-width document --
the markdown sniff only picks the renderer (Markdown vs pre-wrap), so a
text item can no longer fall back to the boxed CONTEXT/TEXT fields view
(the Attio duplicate register did, because its table-only markdown
matched no marker). looksLikeMarkdown gains a GFM table-delimiter
marker, and wide tables scroll horizontally instead of blowing out the
reading column.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
19px read slightly oversized inside the app shell; prose-lg's native 18px on the same 1.6 line-height sits better. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR refines inbox item rendering so any { text } context is treated as a full-width “document” view (never falling back to the boxed labeled-fields layout), improves Markdown detection for GFM tables (including horizontal scrolling for wide tables), and adjusts long-form reading typography from 19px to Tailwind Typography’s native prose-lg sizing (18px).
Changes:
- Treat any non-empty
{ text: string }context as document content; choose Markdown vs pre-wrapped plain text rendering at display time. - Improve Markdown sniffing to recognize GFM table delimiter rows and make rendered tables horizontally scrollable.
- Adjust
Markdown“lg” styling to remove the explicit 19px override (18px default viaprose-lg).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/src/components/markdown.tsx | Updates long-form typography and adds a custom table renderer to wrap tables in overflow-x-auto. |
| web/src/app/[workspace]/inbox/[id]/page.tsx | Renders {text} documents as either Markdown (if detected) or pre-wrapped plain text, both unboxed. |
| web/src/app/[workspace]/inbox/[id]/context-view.tsx | Expands Markdown detection to include GFM table delimiter rows; makes {text} contexts qualify as documents even when plain text. |
| web/src/app/[workspace]/inbox/[id]/context-view.test.ts | Updates tests to cover table delimiter detection and documentText behavior for plain text and empty text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+55
to
+59
| table: (props) => ( | ||
| <div className="overflow-x-auto"> | ||
| <table {...props} /> | ||
| </div> | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #327 from dogfooding:
{ text }context now renders as the unboxed full-width document — the markdown sniff only picks the renderer (Markdown vs pre-wrap for plain text whose line breaks matter), so a text item can never fall back to the boxed CONTEXT/TEXT labeled-fields view. The Attio duplicate register was doing exactly that, because its table-only markdown matched none of thelooksLikeMarkdownmarkers.looksLikeMarkdowngains a table-delimiter-row marker (| --- | --- |, not just any pipe-bearing line), and the Markdown component wraps tables inoverflow-x-autoso a 10-column register scrolls instead of blowing out the reading column.prose-lgnative) — 19px read slightly oversized inside the app shell.Testing
npx vitest run— 28 files / 200 tests pass (table-marker + documentText cases updated),tsc --noEmitclean.🤖 Generated with Claude Code