Improve device deployment UI#39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Deployed graphas theUntitledfallbackWhy
A running robot was shown with a red hardware-monitor error and
Armed: Noeven though the deployment correctly owned and controlled it. Deployment names also fell back toCurrent graph, and several controls could be clipped in compact windows.Impact
Operators can distinguish healthy deployment ownership from actual hardware failures, identify deployments by workflow name, and use device/deployment controls at narrow viewport sizes.
Validation
python -m pytest tests/test_editor_devices.py -q— 32 passedPYTHONPATH=python python -m unittest discover -s tests— 387 passed, 8 skippedcd editor && npm run build— passed