Propagate package paths to robot drivers - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
blacknode-robotpackage rootBLACKNODE_PACKAGE_PATHto childPYTHONPATHPYTHONPATHwhile de-duplicating resolved pathsRoot cause
Workflow package nodes are loaded into the deployment process dynamically.
RobotDriverLauncherthen starts the physical driver as a separate Python process, which inherits environment variables but not the parent process'ssys.pathmutations. The Feetech driver could therefore start ROS but failed on its first canonical telemetry publish when importingblacknode_robot.devices; the Runtime watchdog correctly stopped the deployment after receiving no valid telemetry.Impact
Managed robot drivers can import the stable contracts and helper modules provided by installed extension packages. Startup remains disarmed, torque release behavior is unchanged, and the required-telemetry watchdog remains enforced.
Validation
python -m pytest packages/blacknode-robot/tests -qwith the package root onPYTHONPATH: 102 passed, 2 skippedgit diff --check