ci: fix PHPStan not using result cache

[staabm]

CI debug first, why it doesn't work.. than we will see how a fix looks like

ok, findings are

• we had a bug in PHPStan result cache handling, when projects had composer.lock on gitignore, which we fixed with Result cache fully invalidated when composer.lock changes without any installed package change phpstan/phpstan#14984
• CI should build the cache on the 3.x branch, so new PRs immediately benefit from a warm cache
• updating to latest PHPStan unlocks new performance level (cold cache takes 10 seconds on my local machine to scan ~2600 files; previosly PHPStan 2.1.40 took 20s)
• after updating PHPStan, I fixed upcoming new errors and cleaned up no longer necessary ignore rules

---

relevant changes are in

• .github/workflows/coding-conventions.yml
• composer.json

everything else is handling of PHPStan errors to get the build green

[brendt]

Thanks for looking into it!

So should I still merge this branch? I reckon I can since there are some code fixes in it as well?

[staabm]

the branch is ready to merge, indeed.

I will watch PRs coming in after the merge to make sure it works now as expected

[github-actions]

Benchmark Results

Comparison of patch-1 against 3.x (b7e88b2353a88f17af07e14985afd3b88b5d6b1d).

Open to see the benchmark results

Benchmark	Set	Mem. Peak	Time	Variability
ViewRenderBench(benchPlainHtml)	-	22.015mb +0.00%	504.891μs -5.06%	±1.99% -9.45%

_{Generated by phpbench against commit 6675c72}

[brendt]

@xHeaven could the failing tests here have something to do with your refactor in #2238 ?

[staabm]

I think we also need to update rector for compat with the latest PHPStan release.

rector depends on non API internals of PHPStan, which usually means it easily breaks right after a PHPStan release, see rectorphp/rector-src#8208

[xHeaven]

@xHeaven could the failing tests here have something to do with your refactor in #2238 ?

I don't think so, or at least I don't see anything related. It's likely what @staabm mentioned above.

@staabm If @brendt gives his blessing, I think you can upgrade Rector in this same PR, as it's sort of related.

[staabm]

(fixed the rector update from my company laptop, therefore commited with a different github.com account)

[brendt]

Thanks! Appreciate it :D