ENH: Run an automatic skeleton update on import by default #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 88.05% 88.34% +0.28%
==========================================
Files 5 5
Lines 201 206 +5
==========================================
+ Hits 177 182 +5
Misses 24 24
Continue to review full report at Codecov.
|
oesteban
changed the title
oesteban
left a comment
oesteban
left a comment
There was a problem hiding this comment.
Looking good - I have added two suggestions to avoid this eager update when DataLad is the backend. (after all, that's for power users so those should know how to update themselves - and still can call update() explicitly). Please check it works as expected.
Also, for other PR, some tests would be nice.
| def update(local=False, overwrite=True): | ||
| def update(local=False, overwrite=True, silent=False): | ||
| """Update an existing DataLad or S3 home.""" | ||
| if TF_USE_DATALAD and _update_datalad(): |
There was a problem hiding this comment.
have you checked this update thing with the datalad operation mode? - possibly for a further PR of refinements of that use-case
There was a problem hiding this comment.
nope - though just did and:
Updating TEMPLATEFLOW_HOME using DataLad ...
[ERROR ] path not associated with any dataset [update(/Users/mathiasg/.cache/templateflow)]
/Users/mathiasg/code/templateflow/templateflow/conf/__init__.py:74: UserWarning: Error updating TemplateFlow's home directory (using DataLad): Command did not complete successfully [{'action': 'update', 'path': '/Users/mathiasg/.cache/templateflow', 'type': 'directory', 'raw_input': True, 'orig_request': '/Users/mathiasg/.cache/templateflow', 'status': 'error', 'message': 'path not associated with any dataset'}]
warn(f"Error updating TemplateFlow's home directory (using DataLad): {e}")
so I'll commit your changes to avoid the auto-update if the user prefers DataLad.
|
Bumping this up, any updates? |
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
|
This is ready, correct? |
|
yes - update is still disabled by default when using datalad. do we want to revert that now that #48 is in? |
|
Nope, datalad users are supposed to be knowledgeable enough to call |
|
With this merged, we should cut a new release, DYT? |
|
I'll go for it |
2 participants
closes #44