Skip to content

Conversation

@yarikoptic
Copy link
Contributor

this is due to the change in behavior of 0.12.x series of DataLad.
See datalad/datalad#3759
for more info

Closes #47
Disclaimer: I have not tried the fix anyhow

@oesteban
Copy link
Member

I guess this PR should also include an update to:

datalad ~= 0.11.8

I guess:

    datalad ~= 0.12.0

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #48 into master will decrease coverage by 0.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   88.05%   87.06%   -1.00%     
==========================================
  Files           5        5              
  Lines         201      201              
==========================================
- Hits          177      175       -2     
- Misses         24       26       +2     
Flag Coverage Δ
#api 87.06% <100.00%> (-1.00%) ⬇️
#config 52.23% <100.00%> (-1.00%) ⬇️
#datalad 77.61% <100.00%> (-1.00%) ⬇️
#dls3 41.79% <0.00%> (ø)
#s3 54.22% <0.00%> (ø)
Impacted Files Coverage Δ
templateflow/conf/__init__.py 86.95% <100.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca302ad...13e0217. Read the comment docs.

this is due to the change in behavior of 0.12.x series of DataLad.
See datalad/datalad#3759
for more info
@yarikoptic
Copy link
Contributor Author

done

@oesteban
Copy link
Member

Thx!

@oesteban oesteban merged commit 7a08e40 into templateflow:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure update() works when using DataLad

2 participants