add VerisioningOverride to Child Workflow's on start - #798
Merged
Conversation
Shivs11
commented
Jun 10, 2026
| START_CHILD_WORKFLOW_EXECUTION_FAILED_CAUSE_UNSPECIFIED = 0; | ||
| START_CHILD_WORKFLOW_EXECUTION_FAILED_CAUSE_WORKFLOW_ALREADY_EXISTS = 1; | ||
| START_CHILD_WORKFLOW_EXECUTION_FAILED_CAUSE_NAMESPACE_NOT_FOUND = 2; | ||
| START_CHILD_WORKFLOW_EXECUTION_FAILED_CAUSE_INVALID_VERSIONING_OVERRIDE = 3; |
Member
Author
There was a problem hiding this comment.
the main reason I chose to have an additional cause here is because there could be a world where the version the user is trying to pin their child workflow on does not exist, and so I thought it's best to have a new cause out here since we should not be starting the child workflow in that case
note: if a user tries to start a non child workflow with a versioning override where the version does not exist, we right now do not start that workflow. The intention was to keep the behaviour consistent.
Shivs11
marked this pull request as ready for review
June 10, 2026 20:19
Sushisource
approved these changes
Jun 10, 2026
Shivs11
force-pushed
the
ss/child-workflow-versioning-override-api
branch
from
July 7, 2026 20:28
f67b7f6 to
d0a25cf
Compare
Shivs11
enabled auto-merge (squash)
July 7, 2026 21:03
Shivs11
disabled auto-merge
July 7, 2026 21:03
Shivs11
force-pushed
the
ss/child-workflow-versioning-override-api
branch
from
July 8, 2026 14:58
d0a25cf to
a784d86
Compare
rkannan82
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Breaking changes
Server PR
temporalio/temporal#10646