When delegating to an extension, exit with the same code the extension used#1116
Merged
Merged
Conversation
chaptersix
approved these changes
Jul 9, 2026
chaptersix
added a commit
that referenced
this pull request
Jul 9, 2026
#1112, #1115, #1116) (#1118) Backports the following PRs from `main` to `release/1.8.x`: - #1112 — ci/docs: escape MDX-incompatible patterns and add `-subdir` to gen-docs - #1115 — Bump `go.temporal.io/server` to v1.31.2 (originally merged into `release/1.7.x`) - #1116 — When delegating to an extension, exit with the same code the extension used Cherry-picked in merge order with `-x`. ### Notes - #1115 conflicted on `go.mod`/`go.sum` because `release/1.8.x` was on `go.temporal.io/server v1.31.0`. Resolved by taking `v1.31.2` and regenerating `go.sum` via `go mod tidy`. - `go build ./...` passes; tests for `internal/commandsgen`, `cmd/gen-docs`, and the extension delegation tests pass locally. --------- Co-authored-by: Lina Jodoin <lina.jodoin@temporal.io> Co-authored-by: Jeri Lane <jeri.lane@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
CLDDX-141
What changed?
When delegating to an extension (e.g.
temporal-cloud, non-zero exit codes don't make it back to the user, so there's no programmatic way to know if the command succeeded. This change uses the exit code of the extension as the exit command for thetemporalcommand that wrapped it.Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
temporal <noun> <verb>structure (e.g.temporal workflow start)--search-attribute, bad:--index-field)(Experimental)incommands.yamlHelp text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicableManual tests
Setup
Create an executable file named
temporal-exitsomewhere on your PATHHappy path
Error case