test: fix concurrent start test assertions - #1153
Merged
chaptersix merged 3 commits intoAug 5, 2026
Merged
Conversation
chaptersix
marked this pull request as ready for review
August 5, 2026 15:25
spkane31
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Supersedes #1094, whose contributor is no longer responding. This branch replays Nanook’s two authored commits unchanged so their contribution remains credited, then adds a small maintainer follow-up to restore the successful
client.Dialguard and preserve the accepted cleanup/logging review suggestions.Validation
go test ./internal/temporalcli -run '^TestServer_StartDev_ConcurrentStarts$' -count=1Notes
The original PR remains open and untouched.