Drop selectedLines from the Google GenAI snippets - #5078
Merged
Conversation
Four snippets on the Google GenAI page used `selectedLines` ranges that started partway into the file, so each rendered with a leading `# ...` elision marker. Because that marker sits at column 0, it also suppressed snipsync's dedenting and left the two worker excerpts indented. temporalio/samples-python now scopes the SNIPSTART/SNIPEND markers to exactly this code, so the ranges are no longer needed. Merge the samples change first: the daily snipsync job pulls from samples-python main and would otherwise splice the whole files in. The streaming excerpt gains the consume() function it was missing. Its old range began at a dangling `if` and left out the stream.subscribe() call the surrounding prose describes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
lennessyy
approved these changes
Aug 10, 2026
lennessyy
enabled auto-merge (squash)
August 10, 2026 17:32
Duncanma
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the stray
# ...line at the top of four code samples on the Google GenAI page.Each of the four used a
selectedLinesrange that started partway into the file, so snipsync rendered a leading elision marker. Because that marker sits at column 0, it also zeroed out the common indent prefix and suppressed snipsync's dedenting, leaving the two worker excerpts indented under amain()you never see.temporalio/samples-python#346 scopes the
SNIPSTART/SNIPENDmarkers to exactly the code shown here, so the ranges are no longer needed. Dropping them removes both the marker and the stray indentation.The streaming excerpt also gains the
consume()function it was missing. Its old range began at a danglingifand left out thestream.subscribe()call the surrounding prose describes.Notes to reviewers
Merge temporalio/samples-python#346 first. The daily snipsync job pulls from samples-python
main; if this lands alone, that job splices the whole files back in.Verified by extracting every snippet from the updated sample sources and running snipsync's own
deindent.jsover them — all 15 blocks on the page match, so the next snipsync run is a no-op.vale --config .vale-ci.iniis clean.🤖 Generated with Claude Code
┆Attachments: EDU-6926 Drop selectedLines from the Google GenAI snippets