Add a schedule feature test for ErrScheduleAlreadyRunning#799
Add a schedule feature test for ErrScheduleAlreadyRunning#799lina-temporal merged 1 commit intomainfrom
Conversation
Did you check if this exists in other SDKs? I'm confused what broke if this is adding a new test? |
Yes, it does - TypeScript example.
There wasn't coverage testing the full E2E of duplicate errors (including the SDK piece), so when the error in server changed, nothing showed us that the translation in SDK was no longer working (e.g., we didn't realize we'd broken things). This will also validate the fix PR as features will run against that PR's commits, including w/ CHASM enabled. |
|
@lina-temporal OK, makes sense - can we add other languages then? Super easy to do with coding agents these days and really helps our coverage to have more than just Go |
Sure, I'll add them as well now that this has landed for the fix. Indeed, the Go test was also written with a coding agent, but I opted to reduce the review surface since it's an active incident. |
…ateSchedule duplicate paths (#9866) ## What changed? - Restored previous WorkflowExecutionAlreadyStarted error handling. `CreateSchedule` is special-cased in the SDK such that that specific error is wrapped into an application-level `ScheduleAlreadyExists` error. - CHASM handler still returns `AlreadyExists`, which is translated at the frontend handler level. ## Why? - Broke backwards compatibility with the SDK ## How did you test it? **New feature test to accompany this PR**: temporalio/features#799 - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) - [x] added new feature test(s)
…ateSchedule duplicate paths (#9866) ## What changed? - Restored previous WorkflowExecutionAlreadyStarted error handling. `CreateSchedule` is special-cased in the SDK such that that specific error is wrapped into an application-level `ScheduleAlreadyExists` error. - CHASM handler still returns `AlreadyExists`, which is translated at the frontend handler level. ## Why? - Broke backwards compatibility with the SDK ## How did you test it? **New feature test to accompany this PR**: temporalio/features#799 - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) - [x] added new feature test(s)
…ateSchedule duplicate paths (#9866) ## What changed? - Restored previous WorkflowExecutionAlreadyStarted error handling. `CreateSchedule` is special-cased in the SDK such that that specific error is wrapped into an application-level `ScheduleAlreadyExists` error. - CHASM handler still returns `AlreadyExists`, which is translated at the frontend handler level. ## Why? - Broke backwards compatibility with the SDK ## How did you test it? **New feature test to accompany this PR**: temporalio/features#799 - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) - [x] added new feature test(s)
3 participants
What was changed
Why?