[Scheduler] Restore WorkflowExecutionAlreadyStarted error for all CreateSchedule duplicate paths#9866
Merged
lina-temporal merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
…ateSchedule duplicate paths
chaptersix
reviewed
Apr 8, 2026
Comment on lines
+3618
to
+3619
| return nil, serviceerror.NewWorkflowExecutionAlreadyStarted( | ||
| fmt.Sprintf("schedule %q: concurrent creation detected", request.ScheduleId), "", "") |
Contributor
There was a problem hiding this comment.
can you just return the original error in this case?
Contributor
Author
There was a problem hiding this comment.
I could, but then it wouldn't have the message indicating what had gone wrong (just the generic 'already started').
chaptersix
approved these changes
Apr 8, 2026
tdyas
pushed a commit
that referenced
this pull request
Apr 8, 2026
…ateSchedule duplicate paths (#9866) ## What changed? - Restored previous WorkflowExecutionAlreadyStarted error handling. `CreateSchedule` is special-cased in the SDK such that that specific error is wrapped into an application-level `ScheduleAlreadyExists` error. - CHASM handler still returns `AlreadyExists`, which is translated at the frontend handler level. ## Why? - Broke backwards compatibility with the SDK ## How did you test it? **New feature test to accompany this PR**: temporalio/features#799 - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) - [x] added new feature test(s)
Merged
temporal-cicd bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
…ateSchedule duplicate paths (#9866) ## What changed? - Restored previous WorkflowExecutionAlreadyStarted error handling. `CreateSchedule` is special-cased in the SDK such that that specific error is wrapped into an application-level `ScheduleAlreadyExists` error. - CHASM handler still returns `AlreadyExists`, which is translated at the frontend handler level. ## Why? - Broke backwards compatibility with the SDK ## How did you test it? **New feature test to accompany this PR**: temporalio/features#799 - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) - [x] added new feature test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
CreateScheduleis special-cased in the SDK such that that specific error is wrapped into an application-levelScheduleAlreadyExistserror.AlreadyExists, which is translated at the frontend handler level.Why?
How did you test it?
New feature test to accompany this PR: temporalio/features#799