Restructure cmd/ into conventional cmd/omes + cmd/dev layout#382
Open
lilydoar wants to merge 1 commit into
Open
Restructure cmd/ into conventional cmd/omes + cmd/dev layout#382lilydoar wants to merge 1 commit into
lilydoar wants to merge 1 commit into
Conversation
User-facing change: the CLI is now invoked as `./cmd/omes` (previously `./cmd`) -- e.g. `go run ./cmd/omes run-scenario ...`. README, CI, the worker Dockerfiles, and cmd/dev/test.go are updated; any external scripts that call `go run ./cmd` must switch to `./cmd/omes`. Per Go convention, cmd/ is a container of binary subdirectories, each named after the binary it produces. Previously the omes binary's main lived at the cmd/ root (built via ./cmd, producing a binary named 'cmd' that Docker had to rename with -o), with its implementation factored into a separate package cli plus a one-line cmd/main.go shim purely to keep the cmd/ root tidy. Move the implementation into cmd/omes as package main (func main), delete the cli package indirection and the shim. The omes binary now builds via ./cmd/omes and is named 'omes' automatically. Testing: `go build ./...` passes; `go run ./cmd/omes --help` and `go run ./cmd/omes list-scenarios` work. stack-info: PR: #382, branch: lilydoar/stack/14
lilydoar
force-pushed
the
lilydoar/stack/14
branch
from
dd93d34 to
a939457
Compare
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Restructure cmd/ into conventional cmd/omes + cmd/dev layout
User-facing change: the CLI is now invoked as
./cmd/omes(previously./cmd) -- e.g.go run ./cmd/omes run-scenario .... README, CI, the workerDockerfiles, and cmd/dev/test.go are updated; any external scripts that call
go run ./cmdmust switch to./cmd/omes.Per Go convention, cmd/ is a container of binary subdirectories, each named
after the binary it produces. Previously the omes binary's main lived at the
cmd/ root (built via ./cmd, producing a binary named 'cmd' that Docker had to
rename with -o), with its implementation factored into a separate package cli
plus a one-line cmd/main.go shim purely to keep the cmd/ root tidy.
Move the implementation into cmd/omes as package main (func main), delete the
cli package indirection and the shim. The omes binary now builds via
./cmd/omes and is named 'omes' automatically.
Testing:
go build ./...passes;go run ./cmd/omes --helpandgo run ./cmd/omes list-scenarioswork.