Normalize the CLI-build block across all Dockerfiles#388
Open
lilydoar wants to merge 1 commit into
Open
Conversation
All seven Dockerfiles build the omes CLI with the same set of inputs, but the duplicated block had drifted: java had metrics/scenarios in a different order, dotnet folded an unrelated workers/proto/harness copy into it, typescript appended versions.env, and the build invoked go via different paths (go vs /usr/local/go/bin/go). That divergence is what let the earlier COPY-set regression hide. Unify them on one byte-identical block (the cached go-mod-download pattern): - ensure go is on PATH in every image so the build line is identical - move per-language extras out of the shared block into each file's language-specific section (cli: workers/proto for kitchen-sink-gen; typescript: versions.env; dotnet: workers/proto/harness) The shared block is now identical across all seven (verified by hash). Built cli, go, and ruby images with podman to cover both base-image patterns (golang-native and go-installed-on-PATH). stack-info: PR: #388, branch: lilydoar/stack/20
lilydoar
force-pushed
the
lilydoar/stack/19
branch
from
313f8e9 to
fa3ec3a
Compare
lilydoar
force-pushed
the
lilydoar/stack/20
branch
from
a08a256 to
942d9a9
Compare
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Normalize the CLI-build block across all Dockerfiles
All seven Dockerfiles build the omes CLI with the same set of inputs, but the
duplicated block had drifted: java had metrics/scenarios in a different order,
dotnet folded an unrelated workers/proto/harness copy into it, typescript
appended versions.env, and the build invoked go via different paths
(go vs /usr/local/go/bin/go). That divergence is what let the earlier COPY-set
regression hide.
Unify them on one byte-identical block (the cached go-mod-download pattern):
language-specific section (cli: workers/proto for kitchen-sink-gen;
typescript: versions.env; dotnet: workers/proto/harness)
The shared block is now identical across all seven (verified by hash). Built
cli, go, and ruby images with podman to cover both base-image patterns
(golang-native and go-installed-on-PATH).