Refactor client traits #1022
Merged
Refactor client traits #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce mockable versions of all services
Sushisource
force-pushed
the
client-refactoring
branch
from
d92af4a to
95495ca
Compare
cretz
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Introduce mockable versions of all services
Why?
In preparation for Rust SDK. Needed to do some of this to prove it was even possible to store dyn-safe versions of clients. After doing the hard part of that, it was worth finish things enough to merge-this as-is since it has benefits to Core as well.
Benefits:
In theory this technique can be used for user-provided interceptors as well. There are also other options we can consider.
Checklist
Closes
How was this tested:
Existing tests / compiles
Any docs updates needed?