Skip to content

Refactor client traits #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

Refactor client traits #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ backoff = "0.4"
base64 = "0.22"
derive_builder = { workspace = true }
derive_more = { workspace = true }
dyn-clone = "1.0"
bytes = "1.10"
futures-util = { version = "0.3", default-features = false }
futures-retry = "0.6.0"
Expand Down
496 changes: 241 additions & 255 deletions client/src/lib.rs
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion client/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ fn code_as_screaming_snake(code: &Code) -> &'static str {

/// Implements metrics functionality for gRPC (really, any http) calls
#[derive(Debug, Clone)]
pub struct GrpcMetricSvc {
pub(crate) struct GrpcMetricSvc {
pub(crate) inner: ChannelOrGrpcOverride,
// If set to none, metrics are a no-op
pub(crate) metrics: Option<MetricsContext>,
Expand All @@ -230,6 +230,7 @@ impl fmt::Debug for ChannelOrGrpcOverride {
}
}

// TODO: Rewrite as a RawGrpcCaller implementation
impl Service<http::Request<Body>> for GrpcMetricSvc {
type Response = http::Response<Body>;
type Error = Box<dyn std::error::Error + Send + Sync>;
Expand Down
Loading
Loading