Switched to Rust 1.90 in CI #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Sep 30, 2025
| /// Id used by server for "legacy" queries. IE: Queries that come in the `query` rather than | ||
| /// `queries` field of a WFT, and are responded to on the separate `respond_query_task_completed` | ||
| /// rpc. | ||
| #[allow(unreachable_pub)] // re-exported in supermodule |
Member
There was a problem hiding this comment.
So these technically aren't false positives, it's that they aren't reachable via some feature flag sets (for certain test binaries).
Ideally we'd make sure the cfg stuff is done properly such that we don't need to set the allows here, but, I'm also fine with this for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
To maintain compatibility with current latest Rust version.
Checklist
Unit tests, integration tests and heavy tests pass.