Skip to content

Switched to Rust 1.90 in CI #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
+17 −11
Merged

Switched to Rust 1.90 in CI #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dee96db
Switched to Rust 1.90 in CI
maciejdudko Sep 30, 2025
0ca6c62
Updated Rust in remaining CI jobs too
maciejdudko Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/heavy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.90.0
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/per-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
submodules: recursive
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0
toolchain: 1.90.0
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0
toolchain: 1.90.0
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0
toolchain: 1.90.0
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0
toolchain: 1.90.0
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
Expand All @@ -164,7 +164,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0
toolchain: 1.90.0
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
Expand All @@ -185,7 +185,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0
toolchain: 1.90.0
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
Expand Down
1 change: 1 addition & 0 deletions core/src/internal_flags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use temporal_sdk_core_protos::temporal::api::{
/// may be removed from the enum. *Importantly*, all variants must be given explicit values, such
/// that removing older variants does not create any change in existing values. Removed flag
/// variants must be reserved forever (a-la protobuf), and should be called out in a comment.
#[allow(unreachable_pub)] // re-exported in test_help::integ_helpers
#[repr(u32)]
#[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Copy, Clone, Debug, enum_iterator::Sequence)]
pub enum CoreInternalFlags {
Expand Down
2 changes: 2 additions & 0 deletions core/src/worker/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ pub(crate) use activities::{
NewLocalAct,
};
pub(crate) use wft_poller::WFTPollerShared;

#[allow(unreachable_pub)] // re-exported in test_help::integ_helpers
pub use workflow::LEGACY_QUERY_ID;

use crate::{
Expand Down
1 change: 1 addition & 0 deletions core/src/worker/workflow/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ use tracing::Span;
/// Id used by server for "legacy" queries. IE: Queries that come in the `query` rather than
/// `queries` field of a WFT, and are responded to on the separate `respond_query_task_completed`
/// rpc.
#[allow(unreachable_pub)] // re-exported in supermodule
Copy link
Member

@Sushisource Sushisource Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these technically aren't false positives, it's that they aren't reachable via some feature flag sets (for certain test binaries).

Ideally we'd make sure the cfg stuff is done properly such that we don't need to set the allows here, but, I'm also fine with this for now

pub const LEGACY_QUERY_ID: &str = "legacy_query";
/// What percentage of a WFT timeout we are willing to wait before sending a WFT heartbeat when
/// necessary.
Expand Down
10 changes: 5 additions & 5 deletions fsm/rustfsm_procmacro/tests/trybuild/dupe_transitions_fail.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: Duplicate transitions are not allowed!
--> $DIR/dupe_transitions_fail.rs:5:1
|
5 | / fsm! {
6 | | name SimpleMachine; command SimpleMachineCommand; error Infallible;
7 | |
8 | | One --(A)--> Two;
9 | | One --(A)--> Two;
5 | / fsm! {
6 | | name SimpleMachine; command SimpleMachineCommand; error Infallible;
7 | |
8 | | One --(A)--> Two;
9 | | One --(A)--> Two;
10 | | }
| |_^
|
Expand Down
Loading