Bumping test CLI version - #3054
Merged
Merged
Conversation
GregoryTravis
approved these changes
Sep 4, 2026
Contributor
Can you list which samples stopped working after this bump? A very common cause for this kind of regression on CLI bump is when a test or sample is using trying to use a new/unstable server-side API that need is gated by a dynamic config flag. |
mjameswh
requested changes
Sep 4, 2026
mjameswh
left a comment
mjameswh
left a comment
Contributor
There was a problem hiding this comment.
Please try and at least clarify why some of the samples stopped working after sever bump. My feeling is that is probably a missing dynamic config flag.
mjameswh
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the test CLI server version. That caused some failures in tests, so this is to fix the tests. Full comments left in to ensure that I am fixing the tests and not covering up an unwanted change.
Some of the changes needed are in #3013 - those aren't duplicated here, but maybe they should be?
The CLI server bump is from 1.7.4-standalone-nexus-operations to 1.8.3-server-1.32.0-162.0. Note that doing the same bump in the sample repo makes some of the sample code no longer run.
--Sample code needs an extra dynamic flag, nexusoperation.enableStandalone. That is why it failed.