Update extstore s3 driver key percent encoding to be consistent with other SDKs and S3's safe character guidelines.#1637
Merged
Conversation
…other SDKs and S3's safe character guidelines.
cconstable
force-pushed
the
extstore/consistent-s3-keys
branch
from
910ddd5 to
a42337d
Compare
jmaeagle99
approved these changes
Jul 10, 2026
| _S3_SAFE_CHARS = frozenset(string.ascii_letters + string.digits + "!-_.*'()") | ||
|
|
||
|
|
||
| def _percent_encode(val: str | None) -> str | None: |
Contributor
There was a problem hiding this comment.
nit: _encode_key or _escape_key. It's not just percent encoding.
| _S3_SAFE_CHARS = frozenset(string.ascii_letters + string.digits + "!-_.*'()") | ||
|
|
||
|
|
||
| def _percent_encode(val: str | None) -> str | None: |
Contributor
There was a problem hiding this comment.
TypeScript is doing slightly different things here: https://github.com/temporalio/sdk-typescript/blob/main/contrib/external-storage-s3/src/driver.ts#L57C10-L57C28
Probably should update TS to have the same algorithm.
Java seems to agree with the Python update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Update extstore s3 driver key percent encoding to be consistent with other SDKs and S3's safe character guidelines.
Why?
Adhere to https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html
Checklist
Added tests