chore: update core #1807
Draft
chore: update core #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-olszewski
force-pushed
the
olszewski/update_core
branch
2 times, most recently
from
ab40243 to
cb60d7c
Compare
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
chris-olszewski
force-pushed
the
olszewski/update_core
branch
from
a8da37f to
a720a26
Compare
mjameswh
reviewed
Oct 27, 2025
| nativeConnection: NativeConnection, | ||
| namespace: string | undefined | ||
| namespace: string | undefined, | ||
| public readonly address: string |
There was a problem hiding this comment.
Can you confirm this addition resolves #1787?
There was a problem hiding this comment.
Yes, added a test to verify that when used with .createLocal the field contains the correct address.
I initially missed that this was the public facing test environment class and not the wrapper we use for our own tests. I needed some way to create an additional connection and making this public seemed sensible, but open to other options.
yuandrew
reviewed
Oct 27, 2025
mjameswh
approved these changes
Oct 28, 2025
|
My mistake, i messed up my git while trying to work on my new branch after branching off of your branch 😅 |
This reverts commit e09a2dc.
chris-olszewski
force-pushed
the
olszewski/update_core
branch
from
d1dee88 to
9d197d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
TSIA
Why?
With the code moving, updating core is more involved than usual. Doing this in a separate PR to make it easier to review.
Checklist
Closes N/A
How was this tested:
Existing tests
Any docs updates needed?
I do not believe so