feat(testing): make address of test server public #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
approved these changes
Nov 3, 2025
chris-olszewski
deleted the
olszewski/feat_make_test_server_address_public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Make the address that was used for creating connections publicly available
Why?
There are valid reasons for wanting to know what address the test environment selected such as looking for a free port or wanting to create a new connection.
This feature is needed for eventually updating core as some tests require multiple connections. Split out of #1807
Checklist
Closes [Feature Request] Allow querying the port/address via TestWorkflowEnvironment #1787
How was this tested:
Added unit test just to verify that address gets populated correctly when using
createLocalI believe doc comment addition is sufficient